Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=574575 Alex Orlandi <nyrk71@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nyrk71@xxxxxxxxx --- Comment #2 from Alex Orlandi <nyrk71@xxxxxxxxx> 2010-03-20 20:55:22 EDT --- Informal review rpmlint on spec returns 1 warning: $ rpmlint log5j.spec log5j.spec: W: invalid-url Source0: log5j-1.2.tar.gz 0 packages and 1 specfiles checked; 0 errors, 1 warnings you should specify the upstream download url in Source0. After the build, rpmlint returns 1 error and 10 warning: $rpmlint log5j.spec ../RPMS/noarch/log5j-* log5j.spec:4: W: non-standard-group Application/Development log5j.spec:23: W: non-standard-group Development/Documentation - "Group" needs to be a pre-existing group, like "Applications/Engineering"; run "less /usr/share/doc/rpm-*/GROUPS" to see the complete list. If you create a sub-package "...-doc" with documentation, use the group "Documentation". log5j.spec: W: invalid-url Source0: log5j-1.2.tar.gz - see above log5j.noarch: W: spelling-error Summary(en_US) Amodern -> Modern, A modern, Moderate - I think should be "A modern" in the summary log5j.noarch: W: spelling-error %description -l en_US printf -> print, prints, print f - it is correct; this Warning can be ignored log5j.noarch: E: description-line-too-long C Logger facade that supports printf style message format for both performance and ease of use. - max 79 char per line (see http://fedoraproject.org/wiki/Common_Rpmlint_issues#description-line-too-long) log5j.noarch: W: non-standard-group Application/Development log5j.noarch: W: invalid-license Apache Software License, v. 2.0 - you should use "ASL 2.0" (see http://fedoraproject.org/wiki/Licensing#Good_Licenses for allowed shortname) log5j.noarch: W: no-documentation log5j-javadoc.noarch: W: non-standard-group Development/Documentation - see above log5j-javadoc.noarch: W: invalid-license Apache Software License, v. 2.0 - see above 2 packages and 1 specfiles checked; 1 errors, 10 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review