Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573294 Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flag| |fedora-review? --- Comment #4 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2010-03-20 11:14:32 EDT --- Full review: rpmlint output (src.rpm only, as it doesn't build): $ rpmlint build/RPMS/kadu-0.6.5.4-1.fc14.src.rpm kadu.src:15: W: setup-not-in-prep kadu.src: W: mixed-use-of-spaces-and-tabs (spaces: line 130, tab: line 105) 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Looks fine. -powerkadu subpackage Summary should be improved. Also, module subpackage summaries should mention kadu in my opinion (feel free to ignore). rm -rf $RPM_BUILD_ROOT%{_datadir}/applnk/Internet/kadu.desktop rm -rf $RPM_BUILD_ROOT%{_datadir}/applications/kadu.desktop You don't need -r when removing single files. I'd drop the -f, too. That way you will know when these files disappear. Actually, instead of providing your own .desktop file as Source:, you should patch the included one if necessary and send the patch upstream. You wouldn't need to rm it, then, just run desktop-file-install --delete-original and use the installed one as source. I think some or all of the modules that have separate tarballs should be moved to separate packages. Some of them even have independent versioning, which is not reflected in their subpackage Version: tags. Not terribly important at the moment. Lots of files have no copyright assignment and no licensing information. Please contact the respective upstreams to correct that. globalhotkeys and panelkadu modules are licensed under GPLv3, thus their subpackage License: tags need updating. GPLv3 text is missing, please contact respective upstreams to add it to their tarballs. You don't need %if ... %endif around subpackage definitions, only their %files sections. Removing these will make the specfile a bit more legible. f6290d67c0f45b3f43ff3f35e780615f anonymous_check-0.6.5.3-1.tar.bz2 97cb72c0ab4b5cf897bfbfc3b5ac0379 kadu-0.6.5.4.tar.bz2 7b8b4b93bef27ff9dd815a7ccfb28cd7 kadu-osd_hints-0.1.3.tar.bz2 cba771287dce1894d4bfbaae57e15bae kadu-powerkadu-2.1.2.tar.bz2 2c9950d67172f99523093d22bc396524 kadu-split_messages-0.3.tar.bz2 b0dc5d909d9b7094bafd24a18b9b3b80 kadu-tabs-1.2.3.tar.bz2 6abcc3ab992daeb9820f9156d8d76020 led_notify-0.23.tar.bz2 85fdf695c7fbc58e607dc15278391ab3 mail-0.3.6.tar.bz2 f15b1c1e8933c9ba5a81cc8e19aeadc7 mime_tex-0.6.5.3.tar.bz2 59f7ba01a63464818acaa5ff6fd176d5 plus_pl_sms-0.6.5.4-1.tar.bz2 2b28612576276fc2b87120093428965b globalhotkeys-0.6.5-15.tar.gz 139948fe1197ff8f2a2e0dd52bc2bfc8 panelkadu-0.6.5-5.tar.gz a58b2be2ee7e4489dc80f629b7e6f8f3 senthistory-0.6.5-5.tar.gz --2010-03-20 15:08:11-- http://kadu.net/~patryk/plus_pl_sms/plus_pl_sms-0.6.5.4-1.tar.bz2 Resolving kadu.net... 212.33.90.181 Connecting to kadu.net|212.33.90.181|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2010-03-20 15:08:12 ERROR 404: Not Found. Doesn't build in mock/rawhide/x86_64: /usr/bin/ld: CMakeFiles/kadu.dir/activate.cpp.o: undefined reference to symbol 'XSendEvent' /usr/bin/ld: note: 'XSendEvent' is defined in DSO /usr/lib64/libX11.so.6 so try adding it to the linker command line /usr/lib64/libX11.so.6: could not read symbols: Invalid operation collect2: ld returned 1 exit status -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review