Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575170 --- Comment #4 from Toshio Ernie Kuratomi <a.badger@xxxxxxxxx> 2010-03-19 23:18:24 EDT --- Full review: GOOD: * Upstream tarball is kmymoney, name of package and srpm follows naming guidelines * License is GPLv2 or GPLv3 which is acceptable * License file included * spec file is legible * Source matches upstream * Locales handled with %find_lang * Shared libraries in -libs subpackage. ldconfig is properly run there. * Package owns all directories and files it creates and nothing more * Proper %clean * Macros used consistently * Package contains code, not content * Headers in the -devel subpacakge * No static libs * No pkgconfig files * .so files are in the devel package * devel package properly requires the exact vesion/release of the libs package. * No libtool .la files * Properly contains a .desktop file * No file dependencies * kmymoney has a man page * Package builds in koji * kmymoney starts, runs, imports files from kmymoney2 NEEDSWORK: * License field says GPLv2+ but it's really GPLv2 or GPLv3 due to the license of libkdchart. - Note: not sure if kmymoney upstream is aware of this subtle difference -- it doesn't affect us at the moment * Bundled libkdchart: talked with rdieter. Big can of worms here. Upstream is officially www.kdab.com. However, it looks like their version of the product isn't open source or perhaps just isn't available for download. Koffice has a bundled copy. - Unclear at what point in time the koffice version forked off from upstream. - Unclear if the koffice version is being developed with API changes. - Unclear if they're syncing with the KDAB version. - Unclear if the kmymoney version is a koffice or a kdab fork. - Unclear whether the version in kmymoney is modified from upstream - Unclear what point in time the kmymoney version forked from upstream - Note: one mitigating factor is that the current, kmymoney2 package (which this replaces entirely) contains a bundled libkdchart as well. So this is something of a case of the package continuing to contain a bundled copy since it wasn't caught on initial review of kmymoney2. Those packages are not grandfathered (under the current Guidelines) but we haven't yet removed a package from the distro, preferring to give the maintainer time to figure out a way to fix the problem. - Note: rdieter is working on changes to the current Guidelines that might allow this and other packages in if they fit certain criteria. QUESTIONING: These may need to be fixed here or maybe should result in Guideline changes. * Large amount of docs in the main package but they're intended for online help (Help::KMyMoney Handbook) This seems okay. OTOH, these files are marked as %doc but online help won't work if they're excluded which could fall under the "files marked as %doc should not affect runtime". I note that gnome apps seem to not mark these as %doc. This probably needs to be discussed and either one method decided on or documented in the Guidelines as to why they differ. * (nonblocker) desktop-file-validate is run in %check rather than %install. Should we amend the Guidelines to say to run this in %install or %check? http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage * (nonblocker) You're doing two differences from what's on the ScriptletSnippets page -- both look like they're improvements over what we have there: 1. updates in %postun are done only on package removal. 2. Use of %posttrans instead of %post for update-mime-database and update-desktop-database. Do we want to propose these as updates to the Guidelines? RPMLINT: kmymoney.x86_64: W: hidden-file-or-dir /usr/share/kde4/apps/kmymoney/pics/l10n/de/.directory kmymoney.x86_64: W: hidden-file-or-dir /usr/share/kde4/apps/kmymoney/pics/l10n/ro/.directory - Are these needed? kmymoney.x86_64: E: script-without-shebang /usr/share/kde4/apps/kmymoney/misc/financequote.pl - This should either be set to nonexecutable or have a /usr/bin/perl shebang line added [... Lots of errors like the following for files in debuginfo ..] kmymoney-debuginfo.x86_64: E: world-writable /usr/src/debug/kmymoney-3.96.1/x86_64-redhat-linux-gnu/kmymoney/widgets/ui_kmymoneyreportconfigtab3decl.h 0666 [...] - Probably need to run find . -type f -name '*.h' -exec chmod 0644 kmymoney kmymoney-devel.x86_64: W: obsolete-not-provided kmymoney2-devel kmymoney-libs.x86_64: W: obsolete-not-provided kmymoney2-libs - I'm assuming the API has changed enough that the old package name shouldn't be provided for the library related subpackags. Correct this if that's untrue. kmymoney-devel.x86_64: W: no-documentation - I notice that there's some developer documentation in deverloper-docs but I don't know if it's of any use for developing against kmymoney-devel. If it is, it can be included. kmymoney-libs.x86_64: W: spelling-error Summary(en_US) runtime -> run time, run-time, untimely kmymoney-libs.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, untimely - runtime is a common spelling so no problem here. kmymoney-libs.x86_64: W: summary-not-capitalized C kmymoney runtime libraries - Up to you -- Kmymoney would be okay when taken as a project name, kmymoney if you just think of it as a program. kmymoney-libs.x86_64: W: no-documentation - I don't think there's any documentation needed here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review