Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575085 --- Comment #2 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-03-19 10:01:59 EDT --- (In reply to comment #1) > Looks good, maybe add a Requires: subversion >= 1.4 (see README)?. I don't think it's necessary. 1.4 is a rather old version of subversion, and it is present even in RHEL 5. All current Fedora versions have at least subversion 1.6.6, so we shouldn't really care (and add explicit requires) for anything older. There's even a Fedora guideline against explicit library requires (subversion is a library here): https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires However, F-11 ships with asciidoc-8.2.5, but needed is at least 8.4. I'm thinking of not building rsvndump for F-11 at all, as it will be EOL soon anyway. What do you think, should I add BuildRequires: asciidoc >= 1.4 to guard against users who might want to rebuild it themselves on F-11? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review