Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=517970 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #14 from Martin Gieseking <martin.gieseking@xxxxxx> 2010-03-18 15:05:23 EDT --- Here is the review of your latest package. This time, everything looks fine, so we can finish here. $ rpmlint /var/lib/mock/fedora-12-i386/result/lingot-*.rpm lingot.i686: W: spelling-error %description -l en_US configurability -> configuration, comparability, curability lingot.src: W: spelling-error %description -l en_US configurability -> configuration, comparability, curability 3 packages and 0 specfiles checked; 0 errors, 2 warnings. The warnings of the spell checker can be ignored. --------------------------------- keys used in following checklist: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: File containing the text of the license(s) must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. $ md5sum lingot-0.8.1.tar.gz* ab46e142f47bfb8e8fd565517202e46a lingot-0.8.1.tar.gz ab46e142f47bfb8e8fd565517202e46a lingot-0.8.1.tar.gz.1 [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [+] MUST: If the package does not successfully compile, ... [+] MUST: All build dependencies must be listed in BuildRequires [+] MUST: The spec file MUST handle locales properly. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files ... - no shared libs [.] MUST: If the package is designed to be relocatable, ... - not relocatable [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+] MUST: Permissions on files must be set properly. [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. - no header files [.] MUST: Static libraries must be in a -static package. - no static libs [.] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' - no .pc files [.] MUST: If a package contains library files with a suffix ... [.] MUST: devel packages must require the base package [.] MUST: Packages must NOT contain any .la libtool archives. [+] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: All filenames in rpm packages must be valid UTF-8. [+] SHOULD: The reviewer should test that the package builds in mock. - builds in mock [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [+] SHOULD: The reviewer should test that the package functions as described. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. ------------------------ The package is APPROVED. ------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review