Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225832 Milan Crha <mcrha@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcrha@xxxxxxxxxx --- Comment #4 from Milan Crha <mcrha@xxxxxxxxxx> 2010-03-18 07:29:56 EDT --- As some subpackages are LGPLv2 and some GPLv2, shouldn't the main package has both of them? > %files -n gnome-python2-rsvg > %files -n gnome-python2-gnomedesktop > %files -n gnome-python2-gnomekeyring doesn't contains %defattr(...) line > Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for > directory ownership and usability) There is one .pc file listed. This seems to be all devel package, sort of, from my point of view, but as that I guess it's ok for python to not name package as -devel (you know: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package). Apart of the above I guess it's fine. If I'm wrong with anything, just tell me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review