Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=552999 --- Comment #14 from Andrea Musuruane <musuruan@xxxxxxxxx> 2010-03-17 18:37:49 EDT --- Jon, we are almost done. Everything seems fine except a little glitch in the upstream Makefile. And since you are upstream you have the privilege to fix it instead of patching it :-) $RPM_OPT_FLAGS are passed correctly but you are also using some fixed flag in the Makefile, as in the following example: $(CXX) -g -c main.cpp ^^^^ The "-g" parameters is fixed and cannot be taken out or changed. I suggest you do something like the following. At the beginning of your Makefile declare the CFLAGS you "upstream" want to use. E.g.: CFLAGS = -g This variable will be overwritten if it is passed in the make invocation, like you are already doing in the spec file. Then call the compiler as in this example: $(CXX) $(CFLAGS) -c main.cpp In this way you have complete control of the flags, i.e. for both "upstream" and "downstream". HTH! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review