[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567053

--- Comment #8 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-03-17 03:02:32 EDT ---
For -0.6:
Almost okay.

* Directory ownership issue

  - Your spec file contains:
-------------------------------------------------------
    66  %files
    70  %{_datadir}/%{name}/
    71  %{_datadir}/%{name}/*
-------------------------------------------------------
    Now build.log shows warnings like:
-------------------------------------------------------
   111  warning: File listed twice: /usr/share/uzbl/examples
   112  warning: File listed twice: /usr/share/uzbl/examples/config
   113  warning: File listed twice: /usr/share/uzbl/examples/config/config
   114  warning: File listed twice: /usr/share/uzbl/examples/config/cookies
   115  warning: File listed twice: /usr/share/uzbl/examples/data
....
....
-------------------------------------------------------
    Note that as
    https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes
    shows, "%{_datadir}/%{name}/" list in %files contains the directory
    %{_datadir}/%{name} _and_ all directories/files/etc under this directory.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]