[Bug 556346] Review Request: stage - A 2.5D multi-robot simulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556346

--- Comment #31 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2010-03-16 01:11:24 EDT ---
(In reply to comment #30)
> I created the -doc subpackage because the guidelines mention that if you have a
> large amount of documentation, you may want to consider splitting it all out. 
> Stage generates about 5MB of documentation, which is large compared to the 300k
> devel package, but it's also not like it's 100's of MB.
Correct, whether to ship a separate *-doc package needs to balance the
trade-offs. 

The intention of this section of the FPG had been
a) to spare disk-space on yum repos, because noarch'ed *-doc packages can be
hardlinked within the repos on yum servers.

b) to enable packagers to ship different/older versions of *-docs to avoid
package updates, in cases a binary package update only slightly changed the
package. This typically is helpful in cases, upstreams ship separate
documentation tarballs. It's hardly applicable to doxygen generated *-devel
docs.

c) to support cases, package suites ship documentation suites/sets which depend
on each other but don't necessarily need the corresponding binaries installed.
(I am not aware of any such use case in Fedora).

Apart of these consideration, in general, shipping separate *-doc packages
doesn't make much difference to end-users. To the contrary, in many cases it
has negative side-effects.

E.g. in your case, the devel docs end up in /usr/share/doc/stage-doc-* and not
in /usr/share/doc/stage-devel-* as users normally expect.
Also, your *-doc package ends up as "an empty installed package" when a user
installs it by rpm --exclude-docs.


>  I'm not against the idea of merging -doc with -devel.
The bug in your packaging is your *-doc package containing devel docs only, 
but the devel package not pulling-in its accompanying documentation - This is
clearly a bug, and not helpful to end-users.

2 potential approaches to this issues would be eiher to let *-devel "Require:
*-doc" or to merge the current *-doc package into *-devel.

> The pkg-config Libs line is generated using FLTK.  FLTK doesn't come with a .pc
> file, it comes with its own fltk-config program.  The build system runs
> fltk-config with all of the necessary settings, and collects the libraries
> necessary to link libstage.  It then passes these libraries to its pkg-config
> generator script.
That's the bug. Instead of adding these libraries to *.pc it should add
Requires: <pkg> for those packages it finds a *.pc for.

P.S: Now that this package has been pushed into CVS, I'll BZ these two issues
against this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]