Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573802 --- Comment #2 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-03-16 01:06:27 EDT --- Looks good. There's a demo script and files under music/, why not package them in %doc? This is not a blocker, but please consider adding "%{?perl_default_filter}" to your spec, before the %description block; even if the addition is merely pro-forma for this package. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2054525 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): a5f87cdf2259ee86e898a08984639ff06fa917a9 Audio-Beep-0.11.tar.gz a5f87cdf2259ee86e898a08984639ff06fa917a9 Audio-Beep-0.11.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-Audio-Beep-0.11-1.fc14.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Audio-Beep-0.11-1.fc14.noarch.rpm perl(Audio::Beep) = 0.11 perl-Audio-Beep = 0.11-1.fc14 perl(Audio::Beep::Linux::beep) = 0.11 perl(Audio::Beep::Linux::PP) = 0.11 ====> requires for perl-Audio-Beep-0.11-1.fc14.noarch.rpm beep perl(Carp) perl(constant) perl(Exporter) perl(IO::File) perl(:MODULE_COMPAT_5.10.1) perl(strict) perl(vars) =====> perl-Audio-Beep-0.11-1.fc14.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Audio-Beep-0.11-1.fc14.src.rpm ====> requires for perl-Audio-Beep-0.11-1.fc14.src.rpm perl(ExtUtils::MakeMaker) perl(Test::More) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review