Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567053 --- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-03-15 12:24:48 EDT --- For -0.5: Almost okay * Timestamps https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps - When using "cp" or "install" commands, please also add "-p" option to keep timestamps on installed files. * Scriptlets for icon cache - Please follow below: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache * Directory ownership issue https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes - Currently the following directories themselves are not owned by any packages. ---------------------------------------------------------------- %{_datadir}/%{name}/ ---------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review