[Bug 546451] Review Request: php-pear-HTML-Template-IT - Simple template API.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546451

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #13 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2010-03-14 04:09:49 EDT ---
REVIEW

+ rpmlint
php-pear-HTML-Template-IT.spec: I: checking-url
http://download.pear.php.net/package/HTML_Template_IT-1.3.0.tgz (timeout 10
seconds)
php-pear-HTML-Template-IT.src: I: checking
php-pear-HTML-Template-IT.src: I: checking-url
http://pear.php.net/package/HTML_Template_IT (timeout 10 seconds)
php-pear-HTML-Template-IT.src: I: checking-url
http://download.pear.php.net/package/HTML_Template_IT-1.3.0.tgz (timeout 10
seconds)
php-pear-HTML-Template-IT.noarch: I: checking
php-pear-HTML-Template-IT.noarch: I: checking-url
http://pear.php.net/package/HTML_Template_IT (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines
+ License ok : BSD
+ License is upstream
+ spec in english and legible
+ license file in sources is provided
+ sources match the upstream sources
cbd2fcffd32a39da7b260397156bddbb  HTML_Template_IT-1.3.0.tgz
+ Source URL ok
+ build  on F12.x86_64
+ BuildRequires ok
+ no locale
+ no .so
+ own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
+ use macros consistently
+ no %define
+ contain code
+ small documentation
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ test suite ok after install
phpunit AllTests.php 
PHPUnit 3.4.11 by Sebastian Bergmann.
...................................
Time: 1 second, Memory: 8.50Mb
OK (35 tests, 79 assertions)
+ scriptlets ok
- Final Requires 
/usr/bin/pear  
+ Final Provides ok
php-pear(HTML_Template_IT) = 1.3.0
php-pear-HTML-Template-IT = 1.3.0-2.fc8

PCI output doesn't report any extension nor version dependency
$ pci -p -S -d /usr/share/pear/HTML/Template
+-----------------------------+---------+---+------------+--------------------+
| Files                       | Version | C | Extensions | Constants/Tokens   |
+-----------------------------+---------+---+------------+--------------------+
| ...are/pear/HTML/Template/* | 4.0.7   | 0 | pcre       | FALSE              |
|                             |         |   |            | NULL               |
|                             |         |   |            | PREG_SET_ORDER     |
|                             |         |   |            | TRUE               |
|                             |         |   |            | __FILE__           |
|                             |         |   |            | __LINE__           |
+-----------------------------+---------+---+------------+--------------------+


*** APPROVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]