Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566411 --- Comment #4 from Nikolay Ulyanitsky <lystor@xxxxxxxxxxxxx> 2010-03-13 14:07:22 EST --- Hi Thank you for starting the review. Spec diff: --- umit.spec.orig 2010-02-18 12:29:17.000000000 +0200 +++ umit.spec 2010-03-13 20:44:54.432759235 +0200 @@ -1,19 +1,18 @@ %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} -%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} %endif %global prerelease RC Name: umit Version: 1.0 -Release: 0.1.%{prerelease}%{?dist} +Release: 0.2.%{prerelease}%{?dist} Summary: Nmap frontend Group: Applications/Internet -License: GPLv2 +License: GPLv2+ and LGPLv2+ URL: http://umit.sourceforge.net/ -Source0: http://downloads.sourceforge.net/project/umit/umit/%{version}%{prerelease}/umit-%{version}%{prerelease}.tar.gz +Source0: http://downloads.sourceforge.net/umit/umit-%{version}%{prerelease}.tar.gz # http://trac.umitproject.org/ticket/378 Source1: umit_48x48.png # http://trac.umitproject.org/ticket/378 @@ -29,6 +28,7 @@ BuildRequires: python-sphinx Requires: nmap +Requires: pygtk2 %description @@ -48,19 +48,9 @@ * Use Umit interface through the Web -%package doc -Summary: Documentation for %{name} -Group: Documentation -Requires: %{name} = %{version}-%{release} - - -%description doc -This package contains documentation files for %{name}. - - %prep %setup -q -n %{name}-%{version}%{prerelease} -%patch0 -p1 -b .setup.py +%patch0 -p1 %build @@ -68,30 +58,30 @@ %install -%{__rm} -rf %{buildroot} +rm -rf %{buildroot} %{__python} setup.py install --root %{buildroot} # Remove useless files -%{__rm} %{buildroot}%{_bindir}/uninstall_umit +rm %{buildroot}%{_bindir}/uninstall_umit # Fix permissions -find %{buildroot} -type f -exec %{__chmod} 644 {} \; -%{__chmod} 755 %{buildroot}%{_bindir}/* +find %{buildroot} -type f -exec chmod 644 {} \; +chmod 755 %{buildroot}%{_bindir}/* -# Remove interpreter from site-packages +# Remove a interpreter from the site-packages find %{buildroot}%{python_sitelib} -type f -iname "*py" -exec \ - %{__sed} -i 's/#!\/usr\/bin\/env python//' {} \; + sed -i 's/#!\/usr\/bin\/env python//' {} \; -# Fix file end-of-line encoding -%{__sed} -i 's/\r//' %{buildroot}%{_docdir}/%{name}/html/_sources/plugins.txt +# Fix the file end-of-line encoding +sed -i 's/\r//' %{buildroot}%{_docdir}/%{name}/html/_sources/plugins.txt -# Install icons -%{__install} -pm 0644 %{SOURCE1} %{buildroot}%{_datadir}/pixmaps/%{name} -%{__install} -d %{buildroot}%{_datadir}/icons/hicolor/48x48/apps -%{__ln_s} ../../../../pixmaps/%{name}/%{name}_48x48.png %{buildroot}%{_datadir}/icons/hicolor/48x48/apps/%{name}.png +# Install the icons +install -pm 0644 %{SOURCE1} %{buildroot}%{_datadir}/pixmaps/%{name} +install -d %{buildroot}%{_datadir}/icons/hicolor/48x48/apps +ln -s ../../../../pixmaps/%{name}/%{name}_48x48.png %{buildroot}%{_datadir}/icons/hicolor/48x48/apps/%{name}.png -# Install desktop file -%{__install} -d %{buildroot}%{_datadir}/applications +# Install the desktop file +install -d %{buildroot}%{_datadir}/applications desktop-file-install \ --dir=%{buildroot}%{_datadir}/applications \ %{SOURCE2} @@ -100,7 +90,7 @@ %clean -%{__rm} -rf %{buildroot} +rm -rf %{buildroot} %post @@ -121,6 +111,7 @@ %files -f %{name}.lang %defattr(-,root,root,-) %doc COPYING COPYING_HIGWIDGETS README +%doc %{_docdir}/%{name} %{_bindir}/%{name} %{_bindir}/umit_scheduler.py %{_datadir}/applications/%{name}.desktop @@ -133,12 +124,15 @@ %{python_sitelib}/%{name}-*.egg-info -%files doc -%defattr(-,root,root,-) -%doc %{_docdir}/%{name} - - %changelog +* Sat Mar 13 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.0-0.2.RC +- Add the pygtk2 to the Requires +- Fix the license +- Fix the Source0 +- Remove the unused macro python_sitearch +- Remove the -doc subpackage +- Replace generally useful macros by regular commands + * Fri Feb 05 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.0-0.1.RC - Initial package build Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/umit.spec SRPM URL: http://repo.lystor.org.ua/fedora/12/SRPMS/umit-1.0-0.2.RC.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review