Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573012 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #3 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2010-03-12 13:40:32 EST --- == REVIEW == Bad: - desktop-file-install/desktop-file-validate not used: https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Good: - rpmlint checks return: desktopcouch.src:76: E: hardcoded-library-path in %{buildroot}/usr/lib/desktopcouch/desktopcouch-* python-desktopcouch.noarch: W: no-documentation Both are safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (LGPLv3) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (SHA256: a0704e6c1c381874582eaf82c8dc7498bb3d480aef3bf1ee1548f2ae9775a05f) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime ***** Fix that minor item with the desktop files and I'll approve this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review