Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523877 --- Comment #20 from Chen Lei <supercyper@xxxxxxx> 2010-03-11 23:02:57 EST --- (In reply to comment #19) > (In reply to comment #18) > > I find that CBFlib tarball bundled some external python modules(dREL-ply, > > PyCifRW, ply), maybe we should remove and package those modules separately. > I'm not bothering with any of the python stuff with cbflib, and I don't plan to > unless there is a strong demand/need for it (which I don't forsee). OK, but I still recommand you split -doc and -utils subpackage. CBFlib has a lot of documentation in it and both doc and html_graphics dirs need to be included in -doc subpackage. Also, The gpl.txt should not move out of doc dir, grep gpl\.txt CBFlib.html CBFlib.html:<b>YOU MAY REDISTRIBUTE THE CBFLIB PACKAGE UNDER THE TERMS OF THE <a href=gpl.txt>GPL</a>. grep \.jpg index.html <img alt="[IUCr Home Page]" src="../html_graphics/iucrhome.jpg" ALIGN=MIDDLE></a> <img alt="[CIF Home Page]" src="../html_graphics/cifhome.jpg" ALIGN=MIDDLE></a> <a href="cbf_definition_rev.html"><IMG SRC="../html_graphics/CBFbutton.jpg" <a href="CBFlib.html"><IMG SRC="../html_graphics/cbflibbutton.jpg" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review