Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530251 --- Comment #15 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2010-03-11 15:05:52 EST --- Some initial remarks for 9.11-4 * SourceURL - For sourceforge hosted tarball, please follow https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net * Build failure - Due to DSOlinkage change on F-13, your srpm does not build on F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2046939 http://fedoraproject.org/wiki/UnderstandingDSOLinkChange You can check this behavior on F-12 by adding ----------------------------------------------------------- export LDFLAGS="-Wl,--no-add-needed" ----------------------------------------------------------- before %cmake line. * Dependency for -devel subpackage - "Requires: pkgconfig" is no longer needed (now rpmbuild automatically detects this dependency) - Some header files have dependency for ice-devel For example, ./gbxsickacfr/gbxiceutilacfr/buffer.h has ----------------------------------------------------------- 17 #include <IceUtil/Monitor.h> 18 #include <IceUtil/Mutex.h> 19 #include <IceUtil/Time.h> ----------------------------------------------------------- So gearbox-devel should have "Requires: ice-devel". * ppc64 switch - Maybe following is simpler: ----------------------------------------------------------- %cmake -DENABLE_LIB_BASICEXAMPLE=OFF -DENABLE_LIB_GBXUTILACFR=ON ... \ %ifarch ppc64 -DENABLE_LIB_GBXSICKACFR=OFF \ %else -DENABLE_LIB_GBXSICKACFR=ON \ %endif . ----------------------------------------------------------- * -ice subpackage splitting - Currently this makes no gain. ----------------------------------------------------------- # env LANG=C rpm -ivh --test gearbox-9.11-4.1.fc13.i686.rpm error: Failed dependencies: libGbxIceUtilAcfr.so.1.0.0 is needed by gearbox-9.11-4.1.fc13.i686 ----------------------------------------------------------- * Directory ownership issue https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes - Currently the following directories are not owned by any packages. ----------------------------------------------------------- %{_libdir}/%{name} ----------------------------------------------------------- * rpath https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath ----------------------------------------------------------- $ rpmlint gearbox | grep rpath gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libflexiport.so.1.0.0 ['/usr/lib'] gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libGbxGarminAcfr.so.1.0.0 ['/usr/lib'] gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libGbxUtilAcfr.so.1.0.0 ['/usr/lib'] gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libGbxNovatelAcfr.so.1.0.0 ['/usr/lib'] gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libGbxSmartBatteryAcfr.so.1.0.0 ['/usr/lib'] gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libhokuyo_aist.so.1.0.0 ['/usr/lib'] gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libGbxSerialAcfr.so.1.0.0 ['/usr/lib'] gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libGbxSerialDeviceAcfr.so.1.0.0 ['/usr/lib'] gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libGbxLockFileAcfr.so.1.0.0 ['/usr/lib'] gearbox.i686: E: binary-or-shlib-defines-rpath /usr/lib/libGbxNovatelUtilAcfr.so.1.0.0 ['/usr/lib'] ----------------------------------------------------------- - Please remove these rpaths. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review