Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565502 Dave Malcolm <dmalcolm@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo? | --- Comment #5 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2010-03-11 11:30:24 EST --- A few minor nits: - remove the "# sitelib for noarch packages, sitearch for others (remove the unneeded one)" comment, and just use sitelib. FWIW, these aren't actually needed in Fedora 13 onwards; see: http://fedoraproject.org/wiki/Packaging/Python#Macros on how to conditionalize them - in the %build stanza, remove the comment about removing CFLAGS, and actually remove the CFLAGS :) - the comment in the %files stanza is probably redundant - in future %changelog entries, it can be better to briefly say what the changes were, rather than "specfile changes" - the Summary says "A plugin for reCAPTCHA and reCAPTCHA Mailhide", and I find this wording rather awkward. If I'm reading it right "reCAPTCHA and reCAPTCHA Mailhide" is the functionality being added, but what is the program to which the functionality is being added? If it's "python", then the normal wording would be "Python module" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review