[Bug 558544] Review Request: gdisk - An fdisk-like partitioning tool for GPT disks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=558544

Kalev Lember <kalev@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kalev@xxxxxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |kalev@xxxxxxxxxxxx
               Flag|                            |fedora-review+

--- Comment #5 from Kalev Lember <kalev@xxxxxxxxxxxx> 2010-03-11 06:55:05 EST ---
Fedora review gdisk-0.6.3-1.fc12.src.rpm 2010-03-11

+ OK
! needs attention

rpmlint output:
gdisk.i686: W: spelling-error Summary(en_US) fdisk -> disk, frisk, f disk
gdisk.i686: W: spelling-error %description -l en_US fdisk -> disk, frisk, f
disk
gdisk.src: W: spelling-error Summary(en_US) fdisk -> disk, frisk, f disk
gdisk.src: W: spelling-error %description -l en_US fdisk -> disk, frisk, f disk
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ rpmlint warnings above are harmless and can be ignored
+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package follows the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm. md5sum:
  0a43faf9c990fdf45d371dc623830e11  gdisk-0.6.3.tgz
  0a43faf9c990fdf45d371dc623830e11  Download/gdisk-0.6.3.tgz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
+ Packages does not bundle copies of system libraries
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ %clean contains %{__rm} -rf %{buildroot}
+ Consistent use of macros
+ Package contains code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
n/a Header files should be in -devel
n/a Static libraries should be in -static
n/a Library files that end in .so must go in a -devel package
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ Filenames must be valid UTF-8

! As per https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net ,
use the following for Source0:
Source0:       http://downloads.sourceforge.net/gptfdisk/gdisk-%{version}.tgz

I would suggest to not use %{__command} macros in new spec files, as they are
really not needed and only make the spec file harder to read. Instead of
%{__make}, %{__rm}, and %{__install} I'd use just plain make, rm, and install.
But this is mostly just personal preference, and up to you if you want to
change that.

Package looks good and you can fix Source0 when importing into CVS.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]