Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566412 --- Comment #4 from Nikolay Ulyanitsky <lystor@xxxxxxxxxxxxx> 2010-03-11 05:15:30 EST --- Hi Thank you for starting the review. Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/wapiti.spec SRPM URL: http://repo.lystor.org.ua/fedora/12/SRPMS/wapiti-2.2.1-2.fc12.src.rpm ================================================================================ > Would you move GNU message catalogs (.mo files) to the normal directory Yes. wapiti-2.2.1-std_lib_paths.patch and wapiti-setup.py have been changed. Spec diff: --- wapiti.spec.orig 2010-02-18 12:58:53.000000000 +0200 +++ wapiti.spec 2010-03-11 11:52:09.231822854 +0200 @@ -1,11 +1,10 @@ %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} -%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif Name: wapiti Version: 2.2.1 -Release: 1%{?dist} +Release: 2%{?dist} Summary: A web application vulnerability scanner Group: Applications/Internet @@ -16,7 +15,8 @@ Source1: wapiti-setup.py # Split wapiti sources between site-packages/wapiti/* and /usr/bin/wapiti, # move working dirs (generated_report, scans) from site-packages/wapiti/ to ~/.wapiti/, -# move config dir site-packages/wapiti/config/attacks to /etc/wapiti/attacks +# move config dir site-packages/wapiti/config/attacks to /etc/wapiti/attacks, +# move gettext MO files from site-packages/wapiti/config/language to /usr/share/locale # https://sourceforge.net/tracker/?func=detail&aid=2954112&group_id=168625&atid=847490 Patch0: wapiti-2.2.1-std_lib_paths.patch # Use system libraries BeautifulSoup, httplib2, SocksiPy @@ -63,6 +63,7 @@ # Change files encoding to utf8 for f in ChangeLog_lswww; do iconv -f iso-8859-1 -t utf-8 $f > $f.tmp + touch -r $f $f.tmp %{__mv} $f.tmp $f done @@ -82,12 +83,14 @@ find %{buildroot}%{python_sitelib} -type f -iname "*py" -exec \ %{__sed} -i 's/#!\/usr\/bin\/env python//' {} \; +%find_lang %{name} + %clean %{__rm} -rf %{buildroot} -%files +%files -f %{name}.lang %defattr(-,root,root,-) %doc AUTHORS ChangeLog_Wapiti ChangeLog_lswww README TODO example.txt %dir %{_sysconfdir}/%{name} @@ -98,12 +101,6 @@ %dir %{python_sitelib}/%{name}/ %{python_sitelib}/%{name}/attack/ %dir %{python_sitelib}/%{name}/config/ -%dir %{python_sitelib}/%{name}/config/language/ -%dir %{python_sitelib}/%{name}/config/language/* -%dir %{python_sitelib}/%{name}/config/language/*/LC_MESSAGES -%lang(en) %{python_sitelib}/%{name}/config/language/en/LC_MESSAGES/%{name}* -%lang(es) %{python_sitelib}/%{name}/config/language/es/LC_MESSAGES/%{name}* -%lang(fr) %{python_sitelib}/%{name}/config/language/fr/LC_MESSAGES/%{name}* %{python_sitelib}/%{name}/config/vulnerabilities/ %{python_sitelib}/%{name}/file/ %{python_sitelib}/%{name}/language/ @@ -115,6 +112,10 @@ %changelog +* Thu Mar 11 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 2.2.1-2 +- Move gettext MO files to /usr/share/locale +- Preserve timestamps on documentation files ================================================================================ $ rpmlint wapiti-2.2.1-2.fc12.noarch.rpm wapiti.noarch: E: explicit-lib-dependency python-httplib2 wapiti.noarch: W: spelling-error %description -l en_US webpages -> web pages, web-pages, equipages wapiti.noarch: W: spelling-error %description -l en_US webapp -> web app, web-app, Webern wapiti.noarch: W: spelling-error %description -l en_US fuzzer -> fuzzier, fuzzes, fuzzed wapiti.noarch: W: spelling-error %description -l en_US fopen -> open, f open, fop en wapiti.noarch: W: spelling-error %description -l en_US XPath -> X Path, Path, Expat wapiti.noarch: W: spelling-error %description -l en_US eval -> veal, vela, val wapiti.noarch: W: spelling-error %description -l en_US passtru -> passport, passerby, passer wapiti.noarch: W: spelling-error %description -l en_US ponctual -> punctual, nonfactual, punctuate wapiti.noarch: W: spelling-error %description -l en_US Nikto -> Nikon, Nikita, Nikolai 1 packages and 0 specfiles checked; 1 errors, 9 warnings. python-httplib2 is required but rpm dependency generator can not find it ================================================================================ > * Well, from ./doc/wapiti.1 this software seems to be licensed under > GPLv2 (strict). > > However ./src/report_template/includes/js/excanvas.js is licensed under > ASL 2.0, which is also included in rebuilt binary rpm and unfortunately > GPLv2 and ASL 2.0 is incompatible: > https://fedoraproject.org/wiki/Licensing Also there are many files with MIT license in ./src/report_template/includes/js (canvaschartpainter.src.js, chart.src.js, iecanvas.htc, etc). > Would you ask the upstream about this? Can you give me a full text of the letter which I resend the upstream? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review