Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571502 William Witt <william@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |william@xxxxxxxxxxxxxxx --- Comment #1 from William Witt <william@xxxxxxxxxxxxxxx> 2010-03-10 21:12:51 EST --- Below is an informal review: (extract from http://fedoraproject.org/wiki/Packaging:ReviewGuidelines) * MUST: rpmlint must be run on every package. The output should be posted in the review.[1] [ unamanic@gimli:~ ] $rpmlint /home/unamanic/rpmbuild/SRPMS/pidgin-birthday-reminder-1.4-1.fc12.src.rpm /home/unamanic/rpmbuild/RPMS/x86_64/pidgin-birthday-reminder-1.4-1.fc12.x86_64.rpm /home/unamanic/rpmbuild/RPMS/x86_64/pidgin-birthday-reminder-debuginfo-1.4-1.fc12.x86_64.rpm pidgin-birthday-reminder.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging pidgin-birthday-reminder.x86_64: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging 3 packages and 0 specfiles checked; 0 errors, 2 warnings. * MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [13] is "# Pidgin package doesn't own sounds/pidgin/ dir" a bug against pidgin? * MUST: Each package must consistently use macros. [17] changing $RPM_BUILD_ROOT to %{buildroot} for consitancy would improve consistency * SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [29] are translations available? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review