Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: magicor - Push ice blocks around to extenguish all fires https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210757 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-10-17 17:40 EST ------- Sorry for the delay on this review Good Docs included Upstream and current md5sums check Consistent use of macros Software installs and runs as it should No dependancy and provides problems (sane) Compliant with the python packaging rules Correct use of scriptlets Has a desktop icon spec file in American English and is sane needs work Under %files non-conffile-in-etc /etc/magicor.conf - needs %config (noreplace) before the %{_sysconfdir) needs a %build section (even if it's empty - I'll need to check on this though) Fix the %config bit under needs work and I'm happy to let it in. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review