Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567086 --- Comment #4 from Chen Lei <supercyper@xxxxxxx> 2010-03-10 07:56:00 EST --- (In reply to comment #3) > Hello Chen Lei! > thanks for your comments: > 1) What do you mean "add subpackage info after %description"? Would you mind > writing a small example? > (ie: > %package devel > Summary: Headers for VXL library > Group: Development/Libraries > Requires: %{name} = %{version}-%{release} > %description devel > You should install this package if you would like to > develop code based on VXL. > -> Here I think you should add some more text to clarify <- > ) It's not error, just a spec file standard. You see almost all spec files add subpackage info after %description, follow standard will increase the readability of spec file. See http://cvs.fedoraproject.org/viewvc/rpms/glibc/devel/glibc.spec?revision=1.430&view=markup > 2) As for the bundled libs: > - I've already removed jpeg png zlib tiff geotiff mpeg2 > - v3p/netlib dependency not removed because of heavily modifications > - v3p/dcmtk: it exists an rpm package at http://dicom.offis.de/dcmtk.php.en but > there is none in yum and neither there is a review request. Should we try to > add it as well? > - All of the following libraries are being switched off: > -DBUILD_OXL:BOOL=OFF \ > -DBUILD_CORE_GEOMETRY:BOOL=OFF \ > -DBUILD_CORE_IMAGING:BOOL=OFF \ > -DBUILD_CORE_NUMERICS:BOOL=ON \ > -DBUILD_CORE_PROBABILITY:BOOL=OFF \ > -DBUILD_CORE_SERIALISATION:BOOL=OFF \ > -DBUILD_CORE_UTILITIES:BOOL=OFF \ > -DBUILD_CORE_VIDEO:BOOL=OFF \ > because the main intent for this package was to allow InsightToolkit (which is > blocked by this package review), my idea to speed up the approval was to > disable these functionalities as they are not used in Insight Toolkit and > require a significant effort to be decoupled and packaged as well. > If you can help in packaging and enabling these libraries, I would be more than We should packaging those libs, I can also help you to package some of them. Howerver, if I try to package those libs, I'll need some others to review my packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review