Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562366 --- Comment #21 from Liang Suilong <liangsuilong@xxxxxxxxx> 2010-03-10 03:20:06 EST --- (In reply to comment #20) > rpmlint * > zinnia.src: W: summary-not-capitalized C online handwriting recognition system > with machine learning-> > Online handwriting recognition system with machine learning > > zinnia.src: W: spelling-error %description -l en_US customizable -> > customization, customize, customarily > zinnia.src: W: non-coherent-filename zinnia-0.05-3.fc14.src.rpm > zinnia-0.05-3.fc14.x86_64.rpm-> > > > zinnia.src: W: strange-permission zinnia-0.05.tar.gz 0777L > zinnia.src: W: strange-permission zinnia-0.05-bindings.patch 0777L > zinnia.src: W: strange-permission zinnia.spec 0777L-> > chmod 644 > > zinnia.x86_64: W: summary-not-capitalized C online handwriting recognition > system with machine learning > zinnia.x86_64: W: spelling-error %description -l en_US customizable -> > customization, customize, customarily > zinnia.x86_64: W: shared-lib-calls-exit /usr/lib64/libzinnia.so.0.0.0 > exit@xxxxxxxxxxx This warning still appears. I think that it needs a patch of source codes. I do not know how to fix it. Could you help me write a patch? > zinnia.x86_64: E: zero-length /usr/share/doc/zinnia-0.05/ChangeLog > -> > in %prep > find . -type f -name ChangeLog -size 0c -exec rm -f {} ';' > > zinnia-devel.x86_64: W: no-documentation Here I add %doc README COPYING in all %file sections. The warning disappears. Is it OK? > zinnia-doc.noarch: W: file-not-utf8 > /usr/share/doc/zinnia-doc-0.05/doc/zinnia.css-> > In %prep > sed -i 's/\r//' doc/zinnia.css It seems not to work. I add them in %prep pushd doc iconv -f latin1 -t utf8 zinnia.css > zinnia.css.bak mv -f zinnia.css.bak zinnia.css popd > > > zinnia-perl.x86_64: W: no-documentation > zinnia-perl.x86_64: E: non-standard-executable-perm > /usr/lib64/perl5/auto/zinnia/zinnia.so 0555L-> > chmod 755 > > > zinnia-python.x86_64: W: no-documentation > zinnia-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/zinnia > ['/usr/lib64'] > zinnia-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/zinnia_convert > ['/usr/lib64'] > zinnia-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/zinnia_learn > ['/usr/lib64'] > -> > After %configure > sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool > sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool > > > zinnia-utils.x86_64: W: no-documentation > 8 packages and 0 specfiles checked; 5 errors, 14 warnings. > > > I recommend the following changes: > #%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print get_python_lib()")} > #%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print get_python_lib(1)")} > > %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib())")} > %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} > %endif > -> > %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) > %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib())")} > %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from > distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} > %endif > > > rm -f python/%{name}.pyc > -> > find . -type f -name "*.pyc" -exec rm -f {} ';' > > rm -f $RPM_BUILD_ROOT%{_libdir}/lib%{name}.la > rm -f $RPM_BUILD_ROOT%{perl_vendorarch}/auto/%{name}/%{name}.bs > rm -f $RPM_BUILD_ROOT%{perl_vendorarch}/auto/%{name}/.packlist > -> > find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';' > find $RPM_BUILD_ROOT -type f -name "*.bs" -size 0c -exec rm -f {} ';' > find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';' > > Note:.bs file is useful if it's not a empty file > > %description utils > The %{name}-utils package provide utils for zinnia library that > use %{name}. > -> > %description utils > The %{name}-utils package provides utilities for zinnia library that > use %{name}. > > python setup.py install --root $RPM_BUILD_ROOT > -> > %{__python} setup.py install --root $RPM_BUILD_ROOT > > Note: Choose %{__python} or python, not use both > > CFLAGS="%{optflags}" > -> > CFLAGS="$RPM_OPT_FLAGS" > > Note: Choose %{optflags} or $RPM_OPT_FLAGS, not use both > > %doc doc > ->%doc doc/* The package has the last warning: zinnia.x86_64: W: shared-lib-calls-exit /usr/lib64/libzinnia.so.0.0.0 SPEC: https://dl.dropbox.com/u/1352061/zinnia.spec SRPM: https://dl.dropbox.com/u/1352061/zinnia-0.05-4.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review