Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439630 --- Comment #94 from Henrique "LonelySpooky" Junior <henriquecsj@xxxxxxxxx> 2010-03-09 18:06:26 EST --- (In reply to comment #92) > rm -rf %{buildroot} (in install) I put this because of a rpmlint error: jogl.src: W: no-cleaning-of-buildroot %install > don't use -p in install param > > if you use > mkdir -p %{buildroot}%{_javadir} > why use a few lines later > install -dm 755 %{buildroot}%{_libdir}/%{name} > some place use install some place use cp... > try to be consequent. I have some recycled code here. > don't use "\" line break so much. a 80 chars long lines is not too long, so > most lines shouldn't have to break. Just for aesthetic reasons, or is there any consequences for rpm's generation? (In reply to comment #93) > rpmlint -a | grep "debuginfo-without-sources" > > returns nothing (and I do have quite a number of debuginfo packages installed), > so I suspect that one is a problem. Thank you so much, James, I guess that is time to some googleing and ask for help in the lists. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review