Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: njb-sharp - C# bindings to libnjb https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204700 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-10-17 16:48 EST ------- Okay, I'll build this in a minute. Quick review notes. 1. The macro for %{monodir} is only temporary until FC5 mono is brought in line with FC6 2. You need to be consistent with your macros - you have %{name} and %name as well as %buildroot and %{buildroot}. 3. You need to remove the comment about parallel makes being broken - they're not as it builds fine with them on. 4. Does this generate mono debug info as well as ELF debug info? This is just a query as monodebugger can then handle it ;-) 5. The rm -f *a line needs to be *.a - *a means "any text that ends in a" -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review