Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=571364 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #1 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2010-03-08 16:05:24 EST --- Not a instant success: $ rpm x86_64/man-db-2.5.7-1.fc12.x86_64.rpm Preparing... ########################################### [100%] 1:man-db ########################################### [100%] $ man man man: can't open the manpath configuration file /usr/local/etc/man_db.conf Some comments > mkdir $RPM_BUILD_ROOT/etc/cron.daily > install -m755 %{SOURCE1} $RPM_BUILD_ROOT/etc/cron.daily/man-db.cron could be one line and use sysconfdir macro: install -D -m 0755 %{SOURCE1} $RPM_BUILD_ROOT%{_sysconfdir}/cron.daily/man-db.cron make CC="gcc $RPM_OPT_FLAGS" might change to: make CC="{__cc} $RPM_OPT_FLAGS" might be more explicit here: # documentation and translation %{_mandir}/man1/* %{_mandir}/man5/* %{_mandir}/man8/* Unsure about the %lang stuff, could the %find_lang macro be used. https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files Compile flags is not visible during build, is correct flags used? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review