Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542765 Christian Krause <chkr@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |chkr@xxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |chkr@xxxxxxxxxxx Flag| |fedora-review? --- Comment #3 from Christian Krause <chkr@xxxxxxxxxxx> 2010-03-07 16:03:31 EST --- Since all dependent packages are now available (it looks like that BZ #542759 can be closed now) I'll review this package. Here are two questions: Naming of the packages: since the basename of this pacakge is already libghemical I think it would be better to omit the sub-package "libghemical-libs" and put the library directly in the base package. Data package: What is the purpose of the data files in the -data sub-package? If the library won't work without it, I would rather omit this sub-package as well and put everything into the base package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review