Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: openpbx - The truly open source PBX https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210025 jeff@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From jeff@xxxxxxxxxx 2006-10-16 20:53 EST ------- * source files match upstream (can't compare MD5 since this package currently uses a SVN snapshot). I'd reccomend using "svn export" rather than "svn checkout" to generate the tarball. I'd also recommend a more specific comment on how to generate the tarball. Something like: svn export -r %{snap} svn://svn.openpbx.org/openpbx/trunk openpbx; tar czf openpbx-r%{snap}.tar.gz Not a blocker though... * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint has only acceptable complaints. * %check is not present; no test suite upstream. Package works with a basic config. * shared libraries are present; ldconfig is called properly. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel subpackage. * unversioned .so file is in the -devel subpackage. * no pkgconfig files. * no libtool .la droppings. Approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review