Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: granule - Gtk+-based flashcards program Alias: granule https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210189 bugs.michael@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |bugs.michael@xxxxxxx BugsThisDependsOn| |210187 OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From bugs.michael@xxxxxxx 2006-10-16 19:45 EST ------- $ rpmlint granule-1.2.3-1.src.rpm W: granule summary-ended-with-dot A flashcards program based on Leitner methodology. W: granule non-standard-group Applications W: granule setup-not-quiet E: granule no-cleaning-of-buildroot %install E: granule no-cleaning-of-buildroot %clean * If you use %find_lang (which is a MUST), you need to include its results in the %files section like this: %files -f %{name}.lang The manually added %{_datadir}/locale/*/*/* entry must be removed. * The package does not include several directories: %{_datadir}/granule/ %{_datadir}/granule/xml/ Instead of writing %{_datadir}/granule/xml/* which does not include the "xml" directory itself, you could simply write %{_datadir}/granule/xml/ which includes the "xml" directory and its contents _recursively_. * Don't use the %makeinstall macro when "make DESTDIR=%{buildroot} install" works fine (as is the case with most GNU autotools based tarballs). * At the beginning of the %install section, "rm -rf %{buildroot}" is missing. * The %clean section is missing. * These two > glib-gettextize --copy --force > intltoolize --automake --copy --force ought to be applied in the tarball already. * In %setup, using "%setup -q" gives more quiet output and doesn't list the tarball files when extracting it. Makes build logs much more readable and short and to the point. * Where you run "install ...", prefer "install -p ..." to preserve time-stamps of copied files. Same applies to "cp ..." => "cp -p ...". End-users appreciate this. * Build fails due to missing build requirements: checking for XMLCPP... configure: error: Package requirements (libxml-2.0 >= 2.6.11) were not met: No package 'libxml-2.0' found (!) It's missing "BuildRequires: libxml2-devel"! checking for ASSA... configure: error: Package requirements (assa-3.4 >= 3.4.2) were not met: No package 'assa-3.4' found (!) It's missing "BuildRequires: libassa-devel"! * Build fails here. Attaching log. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review