Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570424 Dominic Hopf <dmaphy@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmaphy@xxxxxxxxxxxxxxxxx --- Comment #1 from Dominic Hopf <dmaphy@xxxxxxxxxxxxxxxxx> 2010-03-05 17:50:21 EST --- A few notes: * Line 30 is not necessary. You're installing /usr/bin/ there, I guess that directory should already exist on any system. ;) To solve the issue you may wanted to solve with that line I suggest to write the line following to that like this: install -Dpm 755 %{SOURCE0} %{buildroot}/%{_bindir}/transmission-remote-cli (the -D is the important switch here, see 'man install') * The full URL to the README.md file is missing, when trying to build the package, that file can not be found * You should preserve timestamps within %install section (-p for install) * You don't need the copy commands in %prep section, since you do any copying with the install commands in %install section * Suggestion how to install the README.md in %install section: install -pm 755 %{SOURCE1} %{buildroot}README.md * This CLI obviously is not developed by the transmission team itself, so the URL http://www.transmissionbt.com/ may not be the correct one. Since I couldn't find a serious looking web page of fagga or this CLI client, I'd suggest to use the "project page" (http://github.com/fagga/transmission-remote-cli) instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review