Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569204 Thibault North <thibault.north@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(thibault.north@gm | |ail.com) | --- Comment #6 from Thibault North <thibault.north@xxxxxxxxx> 2010-03-05 16:27:33 EST --- >I found a createicon.exe which we might need to remove from the source as well. Also, please check whether the requires tag on argyllcms and lcms is really needed to be listed. The vendor tag in desktop-file-install shouldn't be necessary. Fixed. >* MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. -- NEEDSWORK Getting rid of the shared libraries seems to be the best think to do, according to Jan. > * MUST: Each package must consistently use macros. -- NEEDSWORK *Should* be ok. Some people seem to be always macros when possible, some other not. What do you think ? >7] why binaries are renamed? Is there any conflict in filenames with any other existing package? If there is no conflict, it could create confusion for users of older version of this software (where my rtstart (or rt) command disappeared?) Fixed. Well, now calling rtstart actually starts it, but rt fails (requiring shared libs and paths). This should be fixed as soon as rawtherapee will properly find its own path. Updated koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2033824 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review