Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566409 --- Comment #4 from Nikolay Ulyanitsky <lystor@xxxxxxxxxxxxx> 2010-03-05 04:36:46 EST --- Thank you for starting the review. > Please fix SourceURL What error is in the SourceURL? $ spectool -g python-SocksiPy.spec --2010-03-05 11:15:26-- http://downloads.sourceforge.net/project/socksipy/socksipy/SocksiPy%201.00/SocksiPy.tar.gz ... HTTP request sent, awaiting response... 302 Found > %python_sitearch macro is used nowhere. Removed. Spec diff: @@ -1,11 +1,10 @@ %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} -%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")} %endif Name: python-SocksiPy Version: 1.00 -Release: 1%{?dist} +Release: 2%{?dist} Summary: A Python SOCKS module Group: Development/Languages @@ -31,7 +30,9 @@ # Fix file end-of-line encoding for f in README BUGS LICENSE; do - %{__sed} -i 's/\r//' $f + %{__sed} 's/\r//' $f > $f.new + touch -r $f $f.new + %{__mv} -f $f.new $f done %build @@ -55,5 +56,9 @@ %changelog +* Fri Mar 05 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.00-2 +- Remove the unused python_sitearch macro +- Preserve timestamps on documentation files + * Sun Feb 14 2010 Nikolay Ulyanitsky <lystor AT lystor.org.ua> - 1.00-1 - Initial package build $ rpmlint {RPMS/noarch,SRPMS}/python-SocksiPy* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Spec URL: http://repo.lystor.org.ua/fedora/12/SPECS/python-SocksiPy.spec SRPM URL: http://repo.lystor.org.ua/fedora/12/SRPMS/python-SocksiPy-1.00-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review