Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565830 --- Comment #4 from Pravin Satpute <psatpute@xxxxxxxxxx> 2010-03-05 03:51:26 EST --- just some comments on spec file 1) use complete link wget link for source0, no need to create macro for only line 2) dont repeat ln -s %{_fontconfig_templatedir}/%{fontconf}-sa.conf \ %{buildroot}%{_fontconfig_confdir}/%{fontconf}-sa.conf use for loop for it as per /etc/rpmdevtools/spectemplate-fonts-multi.spec 3) for txt in License.txt; do fold -s $txt > $txt.new sed -i 's/\r//' $txt.new touch -r $txt $txt.new mv $txt.new $txt done no need of this only %{__sed} -i 's/\r//' License.txt working fine 4) # get rid of the white space (' ') for PakType Naskh Basic Comparison Chart.pdf PakType\ Naskh\ Basic\ Comparison\ Chart.htm may be add _ in place of 'space' 5) i think no need to change name of upstream file, just add _ instead of "space" PakType\ Naskh\ Basic\ Comparison\ Chart.htm 6) from Readme sed remove sed -i 's/\x95//g' $txt.new as it doesnt have x95 character 7)no need of $cd .. much i think its good to do things from $pwd 8) add .conf file for PakTypeNaskhBasic.ttf as well follow /usr/share/fontconfig/templates/basic-font-template.conf 9) i think %_font_pkg PakTypeNaskhBasic.ttf, should move just before its package. 10) remove unnecessary space from sindhi.conf <string>PakType Nashk Basic Sindhi </string> 11) please add %doc under common files, presently no rpm is getting generated. %files common %defattr(-,root,root,-) %doc .... %dir %{fontdir} ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review