Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567348 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2010-03-03 06:45:30 EST --- Just csome quick comments on your spec file: - Is 'CFLAGS="$RPM_OPT_FLAGS"' really needed? It's a noarch package. - Please use '%global' instead of '%define' https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define - The README is missing in %doc - The license is GPLv3+, source header says '3 of the License, or (at your option) any later version.' - The latest release is 1.0.2 Please take a look at he following page, too : https://fedoraproject.org/wiki/Packaging:Python -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review