[Bug 570111] Review Request: rubygem-right-http-connection - RightScale's HTTP/S module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=570111

--- Comment #5 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2010-03-03 06:20:14 EST ---
(In reply to comment #3)
> 4.) Seems to me like your package name is wrong:
> 
> #  Packages that contain Ruby Gems must be called rubygem-%{gemname} where
> gemname is the name from the Gem's specification. [1]
> [1] http://fedoraproject.org/wiki/Packaging/Ruby
> 
> You turned _s into -s; I doubt there's a reason to do that. There indeed are
> ruby gems with _ in package name:
> http://koji.fedoraproject.org/koji/search?match=glob&type=package&terms=ruby*_*    

(In reply to comment #2)
> 1.) Duplicate %files entries
> 
> warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/right_http_connection-1.2.4/History.txt
> warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/right_http_connection-1.2.4/Manifest.txt
> warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/right_http_connection-1.2.4/README.txt

FIXED.

> 
> 2.) Dependency on ruby(abi) = 1.8 missing

FIXED.

> 
> 3.) Use %global instead of %define wherever it makes sense    

FIXED. (Alway forgot this. Need to write patch for gem2rpm ;)

Spec URL: http://mifo.sk/rubygem-right_http_connection.spec
SRPM URL: http://mifo.sk/rubygem-right_http_connection-1.2.4-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]