Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: harminv - Program and library for solving the harmonic inversion problem https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210824 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2006-10-16 11:30 EST ------- Well, 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * BuildRequires: blas-devel, lapack-devel is not needed. All the libraries needed to rebuild harminv are in atlas-devel, removing blas-devel, lapack-devel from BuildRequires causes no problem for mockbuild. * Requires : - /usr/lib/pkgconfig/harminv.pc says: ----------------------------------------------- prefix=/usr exec_prefix=/usr libdir=/usr/lib includedir=/usr/include Name: Harminv Description: harmonic inversion of time series by filter diagonalization Version: 1.3.1 Libs: -L${libdir} -lharminv -llapack -lcblas -lf77blas -latlas -lm -L/usr/lib/atlas -lgfortranbegin -lgfortran -lm -lgcc_s Cflags: -I${includedir} ----------------------------------------------- This means -devel package should require atlas-devel, gcc-gfortran. ..... But is this really? It seems that -devel package should require only main package. A. I think this harminv.pc should be regarded as useless and just be removed from -devel package. Then "Requires: pkgconfig" can be removed from -devel package. B. If you want to leave harminv.pc, then fix the content or add atlas-devel to Requires for -devel package. 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : 3. Other things I have noticed : * I think man page should be in main package. * %configure F77=gfortran --enable-shared --disable-static --with-cxx F77 is not the option of configure but the environment. So This should be: export F77=gfortran %configure --enable-shared --disable-static --with-cxx -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review