Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565666 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2010-03-02 11:29:31 EST --- Some quick comments on your spec file. - No -devel packages as BuildRequires? - Please use macros instead of hardcoded paths https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Macros - .desktop file is not handled correct https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files - Translation should be handled according the Guidelines https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files - Some files are missing in %doc There is no license file and no license statement in the header of the source file, only the website mentioned that the license is GPLv3+. Please ask upstream to include a copy of the license and add a header with a license statement to the header of the source files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review