[Bug 520621] Review Request: laptop-mode-tools - Scripts to spin down hard drive and save power

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520621

--- Comment #7 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2010-03-02 09:05:45 EST ---
Some comments on your spec file

- Remove the comments at the beginning of the file.
- I think it would be better to switch to %{_mandir}/man*/*.* for the man pages
  Man pages  should not have %doc and '%docdir %{_mandir}' should be removed
- 'disttag' is missing in 'Release'
- The %install section is missing

Is upstream aware of the bug in the installer?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]