Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226476 --- Comment #2 from Vitezslav Crhonek <vcrhonek@xxxxxxxxxx> 2010-03-01 11:37:59 EST --- (In reply to comment #1) > Few things: > must: > dist tag missing Fixed. > buildroot not acceptable (although not used by rpm, should be fixed) Fixed. > %defattr(-,root,root,-) instead of %defattr(-,root,root) Fixed. > Fix missing URL Fixed. (The upstream page doesn't exist, I used latest one from web archive.) > Use versioned provides and obsoletes Fixed. > Summary should not end with dot Fixed. > talk.src:50: E: configure-without-libdir-spec -> consider %configure macro Just tried %configure macro and it leaded to build error, but I'll take a look once more if you think that it's worth of it. > > should: > comment patches and source1,2 Done. All changes are commited in devel branch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review