[Bug 569207] Review Request: perl-Data-JavaScript - Dump perl data structures into JavaScript code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=569207

--- Comment #2 from Chris Weyl <cweyl@xxxxxxxxxxxxxxx> 2010-02-28 22:33:15 EST ---
Looks good.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2020448

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
23b994594b7ca07e6200d7dbc4bb2066fd311e0c Data-JavaScript-1.13.tgz
23b994594b7ca07e6200d7dbc4bb2066fd311e0c Data-JavaScript-1.13.tgz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Data-JavaScript-1.13-1.fc13.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Data-JavaScript-1.13-1.fc13.noarch.rpm
perl(Data::JavaScript) = 1.13
perl-Data-JavaScript = 1.13-1.fc13
====> requires for perl-Data-JavaScript-1.13-1.fc13.noarch.rpm
perl >= 1:5
perl(Encode)  
perl(:MODULE_COMPAT_5.10.1)  
perl(strict)  
perl(vars)  

=====> perl-Data-JavaScript-1.13-1.fc13.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Data-JavaScript-1.13-1.fc13.src.rpm
====> requires for perl-Data-JavaScript-1.13-1.fc13.src.rpm
perl(ExtUtils::MakeMaker)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]