[Bug 559213] Review Request: sugar-typing-turtle - A multilingual animated touch typing trainer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=559213

--- Comment #7 from Sebastian Dziallas <sebastian@xxxxxxxx> 2010-02-27 16:31:45 EST ---
(In reply to comment #1)

[...]

> Issues:
> - the command to install the package should be
> %{__python} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
> instead of
> python ./setup.py install --prefix=$RPM_BUILD_ROOT/%{_prefix}

We discussed this on IRC; it seems like the setup.py file has issues with this
invocation.

> - remove the hidden files.

Done before importing!

> These are not blockers, so the package is APPROVED.    

Thanks for the review... :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]