Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540617 --- Comment #14 from Till Maas <opensource@xxxxxxxxx> 2010-02-27 10:36:27 EST --- I started to get familiar with the python review guidelines again. So here are some minor issues: - %{python_sitelib} is defined in Fedora 13 and newer, so please use this: %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif https://fedoraproject.org/wiki/Packaging:Python#Macros - Instead of BuildRequires: python-devel please use BuildRequires: python2-devel https://fedoraproject.org/wiki/Packaging:Python#BuildRequires - Please use %{version} in Source0: Source0: http://chris-lamb.co.uk/releases/django-lint/django-lint-%{version}/django-lint-%{version}.tar.bz2 This makes it easier to update the spec, because then you maybe only need to adjust the version and can use spectool -g -R to download the matching source file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review