Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226534 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@xxxxxxxxxxxxxxxxx --- Comment #4 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-02-27 07:58:00 EST --- Some other issues: - there is no URL - no parallal make https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make - please use INSTALL="install -p" when running make install - why do you enable-static and rm $RPM_BUILD_ROOT/%{_libdir}/lib%{name}.a? please use disable-static and rm $RPM_BUILD_ROOT/%{_libdir}/lib%{name}.a is not needed. - all defattr/attr are missing the last argument: %defattr(-,root,root) vs %defattr(-,root,root,-) - mixed-use-of-spaces-and-tabs (spaces: line 170, tab: line 454) - Prereq is deprecated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review