Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566171 --- Comment #9 from Manuel F Martinez <manpaz@xxxxxxxxxxxxx> 2010-02-27 06:44:41 EST --- Thanks Michael, great advise, I appreciate your hard work. Well, answering in the same way: > 2. I set "GPLv3+" manually because I saw on COPYING file, which originally doesn't come from SVN, but it is there after run autogen.sh, then I realise the upstrem claims in its website that libhid is released under "GPLv2". > 4. Thanks, "autoreconf -i" does the work really nice. > --enable-maintainer-mode Sorry, I left this option there when I was trying to fix an error with manpages generation, then I forgot to remove. > rm -rf ${RPM_BUILD_ROOT%{_libdir}/*.la Removed. > sed -ie /pkgpy/s/libhid/hid/g Makefile # Use 'hid' module name instead 'libhid' > sed -ie /pkgpy/s/libhid/hid/g swig/Makefile # Use 'hid' module name instead 'libhid' I had to have this becuase, previous releases were using hid as namespace for python module, and my apps was being broken. Well, I should admit the package is not only for my use, so I remove the lines from spec file and fixed my apps, Sorry, my bad. > -BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) > +BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXX) Typo error from me, I just tried root instead XXXXXX, then restored back the wrong string. Sorry again. > -make CFLAGS="$CFLAGS" > - > +make CFLAGS="$CFLAGS" CFLAGS is no longer necessary because "autoreconf" is doing very well the work, so I'm removing CFLAGS and adding %{?_smp_mflags}. > %defattr(-,root,root) File permissions now has been set to %defattr(-,root,root,-) as defined in the guidelines > +%ifnarch i686 > %{python_sitearch}/* > +%endif Fixed conditional as suggested: %{python_sitelib}/* %ifarch x86_64 ppc64 sparc64 %{python_sitearch}/* %endif Please, note the s390x architecture is not included, since upstream doesn't recommend to build libhid on such arch. At the end, I'd like to ask you, if you mind to check if the patch comment is ok. I'm applying this patch since the upstream is building manpages with xsltproc with the xslt templates in a location that only works on Debian, so I'm using db2x_docbook2man in order to generate manpages safely. This is why I have added the brief comment, as the Guidelines suggest. https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment New release is available at: Spec URL: http://repo.bashlinux.com/rpm/fedora/12/bashlinux/SPECS/libhid.spec SRPM URL: http://repo.bashlinux.com/rpm/fedora/12/bashlinux/SRPMS/libhid-0.2.17-3.fc12.src.rpm Thank you for your time and patience, I'll be waiting for new comments. Whenever you have a chance. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review