[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508750

--- Comment #21 from David A. Wheeler <dwheeler@xxxxxxxxxxxx> 2010-02-26 12:07:08 EST ---
I still don't have the right .src.rpm to review.  Please upload the .src.rpm
you intend for me to review, and post the correct URL.

Comment #18 *cannot* be correct.  Please let me explain why.
Comment #18 asks me to review:
  http://sundaram.fedorapeople.org/packages/trash-cli-0.11.2-1.fc12.src.rpm

But this can't be right:
 1. The spec file embedded in the .src.rpm is NOT the same as
the spec file as posted in comment #18:
    http://sundaram.fedorapeople.org/packages/trash-cli.spec
 2. The .src.rpm filename URL is *still* release -1 (notice the "-1"
    near the end), but we are at release -2.

I tried to work around this myself by loading:
  http://sundaram.fedorapeople.org/packages/trash-cli-0.11.2-2.fc12.src.rpm
That *did* load a file, but the spec file in this .src.rpm
is *also* not the same as:
  http://sundaram.fedorapeople.org/packages/trash-cli.spec
For example, the RPM spec file description in this .src.rpm file says "trash"
replaces "rm", but the package actually packages "trash-put" and *NOT* "trash".

You've posted a .spec file:
  http://sundaram.fedorapeople.org/packages/trash-cli.spec
But neither .src.rpm that I have includes this spec file;
they both include something *different*, and in both cases they can't be right.

Please do an "rpmbuild -bs trash.spec", post the resulting file, and post the
resulting .src.rpm file URL.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]