Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226389 --- Comment #6 from Nils Philippsen <nphilipp@xxxxxxxxxx> 2010-02-26 11:22:44 EST --- - PASS: rpmlint sane-frontends.src: W: spelling-error Summary(en_US) frontend -> fronted, front end, front-end sane-frontends.src: W: spelling-error %description -l en_US scanadf -> scandal, scanned, scandium sane-frontends.src: W: spelling-error %description -l en_US xcam -> cam, scam, x cam sane-frontends.x86_64: W: spelling-error Summary(en_US) frontend -> fronted, front end, front-end 2 packages and 0 specfiles checked; 0 errors, 4 warnings. "frontend" is a usual form of spelling this term, "scanadf" and "xcam" are names of binaries - GOOD: package is named according to Package Naming Guidelines - GOOD: spec file named correctly - GOOD: package meets Packaging Guidelines - GOOD: licensed with approved license and meets Licensing Guidelines - GOOD: license field matches actual license - BAD: license text not contained as documentation - GOOD: spec file written in American English - GOOD: spec file is legible - GOOD: source matches upstream - GOOD: package already build multiple times in koji - GOOD: all build dependencies listed - N/A: no locale files included - N/A: no libraries in system paths included - GOOD: does not bundle copies of system libraries - N/A: not relocatable - BAD: does not own all directories it creates: /usr/share/sane/sane-style.rc - GOOD: no duplicate file listings - GOOD: file permissions set properly - GOOD: has %clean - BAD: inconsistently uses $RPM_BUILD_ROOT, %buildroot - GOOD: contains code - N/A: no large documentation - GOOD: %doc doesn't affect runtime - N/A: no header files - N/A: no static libs - N/A: no pkgconfig files - N/A: no library files - N/A: no devel package - N/A: no libtool archives - BAD: no desktop files for GUIish xcam program, no explanation either - GOOD: doesn't own files of other packages - GOOD: removes buildroot in %install - GOOD: all file names valid UTF-8 --> recommendations: 1. add license file COPYING to %doc, consider adding AUTHORS, README as well 2. don't distribute /usr/share/sane/sane-style.rc since it's only used by xscanimage (which we don't ship) 3. use either %buildroot or $RPM_BUILD_ROOT consistently 4. explain why xcam has no desktop file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review