Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568641 Jan Vcelak <jvcelak@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(jzeleny@xxxxxxxxx | |m) --- Comment #1 from Jan Vcelak <jvcelak@xxxxxxxxxx> 2010-02-26 05:14:48 EST --- [ ] rpmlint $ rpmlint -i ./*.rpm lldpad.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. lldpad.x86_64: E: incoherent-subsys /etc/rc.d/init.d/lldpad dcbd The filename of your lock file in /var/lock/subsys/ is incoherent with your actual init script name. For example, if your script name is httpd, you have to use 'httpd' as the filename in your subsys directory. It is also possible that rpmlint gets this wrong, especially if the init script contains nontrivial shell variables and/or assignments. These cases usually manifest themselves when rpmlint reports that the subsys name starts a with '$'; in these cases a warning instead of an error is reported and you should check the script manually. 4 packages and 0 specfiles checked; 1 errors, 1 warnings. [*] meets Naming Guidelines [*] meets Licensing Guilelines [*] sources match upstream version [?] all patches have upstream bug link or comment No comments at all (although the meaning is quite obvious from their names). [*] license specified in specfile, license file included [*] specfile in American English [*] specfile is legible [*] valid BuildRoot [*] buildroot cleanup before %install [ ] uses macros consitently Please, use either %{xxx} style or $XXX style macros. Pick a style and use it consistently throughout your packaging. I suggest replacing $RPM_BUILD_ROOT with %{buildroot} Example from your specfile: mkdir -p $RPM_BUILD_ROOT%{_initddir} [*] pkgconfig files in -devel subpackage [*] no static libraries included [*] no staticly linked executables [*] scriptlets requirements splitted [*] %preun, %postun scriptlets running only in certain situations [*] scriptlets are sane [*] package is relocatable [*] all files and directories included [*] permissions and ownership specified [*] all filenames valid UTF-8 [*] contains code, or permissible content [*] documentation doesn't need separate package [*] %doc does not affect runtime [*] subpackages with fully versioned dependency [*] builds in koji Package rename requirements: [*] Provides is correct [*] Obsoletes is correct -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review