Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568148 Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomspur@xxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tomspur@xxxxxxxxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Thomas Spura <tomspur@xxxxxxxxxxxxxxxxx> 2010-02-25 17:31:27 EST --- Review: Good: - name ok - group ok - BR/R ok - macros everywhere - no *.la - no libs - noarch ok - license ok - builds in mock - source match upstream: cef66530225cc63caaf8b878020b333d Needswork: - $ rpmlint python-squaremap-1.0.0-0.1.b24.fc12.src.rpm noarch/python-squaremap-1.0.0-0.1.b24.fc12.noarch.rpm python-squaremap.src: W: spelling-error Summary(en_US) wxPython -> python, Python, diphthong python-squaremap.src: W: spelling-error %description -l en_US wxPython -> python, Python, diphthong python-squaremap.noarch: W: spelling-error Summary(en_US) wxPython -> python, Python, diphthong python-squaremap.noarch: W: spelling-error %description -l en_US wxPython -> python, Python, diphthong python-squaremap.noarch: W: no-documentation python-squaremap.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/squaremap/squaremap.py 0644 /usr/bin/env 2 packages and 0 specfiles checked; 1 errors, 5 warnings. Spelling error is ignoreable, but you need to remove the shebang, because this file is not intented to run. - no-documentation: There is no LICENSE file. Please query upstream to add one. - You should be more explicit in %files to be notified, when the egg is not build: e.g. %{python_sitelib}/squaremap %{python_sitelib}/Squaremap-*.egg-info __________________________________________________________ This are only minor issues, which I'm sure, you'll fix before importing. __________________________________________________________ APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review