Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-DB-QueryTool - An OO-interface for easily retrieving and modifying data in a DB Alias: pear-DB-QueryTool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=210783 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From tibbs@xxxxxxxxxxx 2006-10-15 16:32 EST ------- Everything looks fine; the only question I have is why the documentation is down in a couple of subdirectories: /usr/share/doc/php-pear-DB-QueryTool-1.0.3 /usr/share/doc/php-pear-DB-QueryTool-1.0.3/docs /usr/share/doc/php-pear-DB-QueryTool-1.0.3/docs/examples /usr/share/doc/php-pear-DB-QueryTool-1.0.3/docs/examples/example.php [...] Perhaps the "docs" subdirectory could be eliminated. In any case, I don't think it's a blocker; it just looks a bit odd. * source files match upstream: 6b93afe58f4e5bdd2f198b2b6d7acefa DB_QueryTool-1.0.3.tgz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not separately included upstream (although it is in the source files). * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: php-pear(DB_QueryTool) = 1.0.3 php-pear-DB-QueryTool = 1.0.3-1.fc6 = /bin/sh /usr/bin/pear php-pear(DB) php-pear(Log) php-pear(PEAR) * %check is not present; there is some form of test suite, but it is not possible to run it at build time. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (pear module installation) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review