Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567733 --- Comment #3 from Thomas Janssen <thomasj@xxxxxxxxxxxxxxxxx> 2010-02-25 11:47:47 EST --- XX - Package meets naming and packaging guidelines http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files says: For new packages, do not apply a vendor tag to desktop files. OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 1bb038efb7a9847697bdbf671feb7f6e marave-0.7.tar.gz NN - Package needs ExcludeArch OK - BuildRequires correct NN - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot has: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX) OK - Package is code or permissible content. NN - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. NN - Headers/static libs in -devel subpackage. NN - Spec has needed ldconfig in post and postun NN - .pc files in -devel subpackage/requires pkgconfig NN - .so files in -devel subpackage. NN - -devel package Requires: %{name} = %{version}-%{release} NN - .la files are removed. OK - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. XX - No rpmlint output. marave.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 3) Well, yeah marave.spec: W: invalid-url Source0: http://marave.googlecode.com/files/marave-0.7.tar.gz HTTP Error 404: Not Found spectool -g gets the source. No idea what's wrong there. marave.src: W: spelling-error %description -l en_US ommwriter -> copywriter, songwriter, ghostwriter Bogus, can be ignored. marave.src: W: non-standard-group Unspecified It's missing the Group tag in spec file. marave.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/marave/editor/spelltextedit.py 0644 /usr/bin/env The file contains a shebang. Is that meant to have one? 2 packages and 1 specfiles checked; 1 errors, 10 warnings. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should function as described. OK - Should have sane scriptlets. NN - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review